chore: optimize zonal tests cloning and fix paths#16581
Merged
chandra-siri merged 4 commits intogoogleapis:mainfrom Apr 9, 2026
Merged
chore: optimize zonal tests cloning and fix paths#16581chandra-siri merged 4 commits intogoogleapis:mainfrom
chandra-siri merged 4 commits intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the zonal test execution environment to use a sparse checkout of the google-cloud-python monorepo instead of the standalone python-storage repository. It also adjusts the Cloud Build configuration to point to the new script location. Review feedback suggests improving script reliability by adding set -e, fetching the specific commit SHA directly for better robustness, and reconsidering the removal of zonal snippet tests to maintain test coverage.
chalmerlowe
approved these changes
Apr 8, 2026
Contributor
chalmerlowe
left a comment
chalmerlowe
left a comment
There was a problem hiding this comment.
LGTM.
With the following caveat. I am not an expert in cloudbuild and how it should work. Having said that, I don't see anything here that causes me great concern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes to optimize zonal tests cloning and fix paths.