chore: librarian release pull request: 20260409T112159Z#16596
chore: librarian release pull request: 20260409T112159Z#16596chalmerlowe wants to merge 3 commits intomainfrom
Conversation
fix(deps): require protobuf >= 4.25.8, < 8.0.0 feat: migrate core library code from split repo Note: Python 3.8 is no longer supported.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the google-cloud-storage library to version 3.11.0, which includes raising the minimum supported Python version to 3.9 and updating protobuf dependencies. It also standardizes service_config entries across various API definitions in the .librarian/state.yaml file and removes a copyright header from it. Feedback indicates that the CHANGELOG.md for google-cloud-storage has an imprecise description for the Python version change, a malformed commit hash, and an inconsistent repository name in a version comparison URL that could result in a broken link.
| ### Features | ||
|
|
||
| * drop support for Python 3.8 ([b762ffdcb7c9ceced8b67f7b225c52f38f96444f](https://github.com/googleapis/google-cloud-python/commit/b762ffdcb7c9ceced8b67f7b225c52f38f96444f)) | ||
|
|
||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * require protobuf >= 4.25.8, < 8.0.0 ([b762ffdcb7c9ceced8b67f7b225c52f38f96444f](https://github.com/googleapis/google-cloud-python/commit/b762ffdcb7c9ceced8b67f7b225c52f38f96444f)) |
There was a problem hiding this comment.
There are a couple of issues with this changelog section:
- Imprecise description: The entry 'drop support for Python 3.8' is slightly misleading. The
README.rstfile update indicates that the minimum supported version is now Python 3.9, which means support for Python 3.7 was also dropped. For clarity, consider updating this to 'raise minimum Python version to 3.9' or 'drop support for Python 3.7 and 3.8'. - Malformed commit hash: The commit hash
b762ffdcb7c9ceced8b67f7b225c52f38f96444fappears to be invalid. A standard Git SHA-1 hash is 40 hexadecimal characters, but this one is 48. This will result in broken links. Please correct the hash. The PR description referencesb762ffdc, which might be related.
|
|
||
| [1]: https://pypi.org/project/google-cloud-storage/#history | ||
|
|
||
| ## [3.11.0](https://github.com/googleapis/google-cloud-python/compare/google-cloud-storage-v3.10.1...google-cloud-storage-v3.11.0) (2026-04-09) |
There was a problem hiding this comment.
The repository in the version comparison URL has been changed to google-cloud-python. Previous release entries in this file point to python-storage. This inconsistency may lead to a broken link if this change is not intentional as part of a repository migration.
|
This PR is one step in clearing Issue #16487, namely ensuring the changelog reflects dependency and runtime changes. Other PRs that help to clear Issue #16487 include:
|
parthea
added
the
do not merge
|
This is not ready since #16487 is still open |
2 participants
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release.
Librarian Version: v0.8.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:234b9d1f2ddb057ed7ac6a38db0bf8163d839c65c6cf88ade52530cddebce59e
google-cloud-storage: 3.11.0
3.11.0 (2026-04-09)
Features
Bug Fixes