Skip to content

test: remove the system tests from the generator #8150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
danieljbruce wants to merge 40 commits into
base: main
Choose a base branch
from
Draft

test: remove the system tests from the generator #8150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
3784051
first instruction to remove the system tests
danieljbruce Apr 30, 2026
cc021f1
remove the system tests
danieljbruce Apr 30, 2026
b6efacf
first commit remove the system tests from the generator
danieljbruce Apr 30, 2026
4ff8ff1
chore: cleanup unauthorized changes and restore test scripts
danieljbruce Apr 30, 2026
f9b61db
remove unnecessary changes
danieljbruce Apr 30, 2026
fe428fa
reframe entire problem and do commit
danieljbruce Apr 30, 2026
2931215
remove the skipSystemTest flag
danieljbruce Apr 30, 2026
057e70d
Next update: no fancy scripts
danieljbruce Apr 30, 2026
6f5f94c
undo fancy logic for if/else test control
danieljbruce May 1, 2026
15e8d7e
remove unnecessary line
danieljbruce May 1, 2026
3a975d9
Updated baselines and fixtures
danieljbruce May 1, 2026
8575392
Revert "Updated baselines and fixtures"
danieljbruce May 1, 2026
9bfc484
Revert out of scope changes to package file
danieljbruce May 1, 2026
daa086a
Remove system tests from the include array
danieljbruce May 1, 2026
05f73d3
Eliminate systems tests from the fixtures
danieljbruce May 1, 2026
13c69fc
get rid of non fixtures njk file
danieljbruce May 1, 2026
37cb60b
Get rid of fixtures njk file
danieljbruce May 1, 2026
b94ecf1
Remove the system test folders
danieljbruce May 1, 2026
eef0981
fix typo
danieljbruce May 1, 2026
90e95ad
Add typescript_packing_test back in.
danieljbruce May 1, 2026
324d70e
Delete the final system test folder
danieljbruce May 1, 2026
d9e2a2f
Eliminate the pack-n-play dependency
danieljbruce May 1, 2026
b2fc1e9
add baseline changes
danieljbruce May 1, 2026
1d62970
Revert "add baseline changes"
danieljbruce May 1, 2026
ab6beac
Remove the pack and play dependency
danieljbruce May 1, 2026
ca00710
run baseline script
danieljbruce May 1, 2026
7cd80c8
test: remove the system tests from the generator
danieljbruce May 1, 2026
4eefd74
Merge branch 'remove-the-system-tests-generator' of https://github.co…
danieljbruce May 1, 2026
a9f8c5b
Revert "run baseline script"
danieljbruce May 1, 2026
2bc147c
run the baseline script
danieljbruce May 1, 2026
043622f
Revert "run the baseline script"
danieljbruce May 1, 2026
d5affc9
revert njk file changes
danieljbruce May 1, 2026
ac484fb
run the baseline script
danieljbruce May 1, 2026
0bdc305
Revert "run the baseline script"
danieljbruce May 4, 2026
104621b
remove system test folder deletions
danieljbruce May 4, 2026
64cf219
Revert "remove system test folder deletions"
danieljbruce May 4, 2026
5a04e5b
revert system test folder deletions
danieljbruce May 4, 2026
cda4d9c
run baseline again
danieljbruce May 4, 2026
ff7d65e
Merge branch 'main' into remove-the-system-tests-generator
danieljbruce May 4, 2026
99463fa
Merge branch 'main' into remove-the-system-tests-generator
danieljbruce May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 1 addition & 5 deletions core/generator/gapic-generator-typescript/baselines/asset-esm/.eslintignore.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,5 @@
build/
docs/
protos/
system-test/
samples/
esm/src/**/*.d.ts
esm/test/**/*.d.ts
esm/system-test/**/*.d.ts
esm/system-test/fixtures/sample/src/*.ts
esm/src/**/*.d.ts
2 changes: 0 additions & 2 deletions core/generator/gapic-generator-typescript/baselines/asset-esm/.gitignore.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
/docs/
/out/
/build/
system-test/secrets.js
system-test/*key.json
*.lock
.DS_Store
package-lock.json
Expand Down
33 changes: 0 additions & 33 deletions core/generator/gapic-generator-typescript/baselines/asset-esm/.mocharc.cjs.baseline
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions core/generator/gapic-generator-typescript/baselines/asset-esm/.nycrc.baseline
View file
Open in desktop

This file was deleted.

27 changes: 0 additions & 27 deletions ...tor-typescript/baselines/asset-esm/esm/system-test/fixtures/sample/src/index.cjs.baseline
View file
Open in desktop

This file was deleted.

27 changes: 0 additions & 27 deletions ...ator-typescript/baselines/asset-esm/esm/system-test/fixtures/sample/src/index.js.baseline
View file
Open in desktop

This file was deleted.

33 changes: 0 additions & 33 deletions ...ator-typescript/baselines/asset-esm/esm/system-test/fixtures/sample/src/index.ts.baseline
View file
Open in desktop

This file was deleted.

55 changes: 0 additions & 55 deletions ...erator/gapic-generator-typescript/baselines/asset-esm/esm/system-test/install.ts.baseline
View file
Open in desktop

This file was deleted.

Loading
Loading