test: remove the system tests from the generator#8150
test: remove the system tests from the generator#8150danieljbruce wants to merge 40 commits intomainfrom
Conversation
This reverts commit 3a975d9.
There was a problem hiding this comment.
Code Review
This pull request removes system and unit test configurations, scripts, and baseline files across multiple generator baselines, including asset, bigquery, and compute. The reviewer identified a critical issue where the PR exceeds its stated scope by deleting unit tests and core testing dependencies like mocha, sinon, and c8 alongside the intended system test removals. Furthermore, inconsistencies were found in the compute-esm baseline, where test references were partially removed without corresponding file deletions or configuration updates.
I am having trouble creating individual review comments. Click here to see my feedback.
core/generator/gapic-generator-typescript/baselines/asset-esm/package.json (66-68)
The PR title indicates the removal of the system tests generator, but these changes also remove the unit test scripts (test:cjs, test:esm, test), the corresponding unit test files (e.g., esm/test/gapic_asset_service_v1.ts.baseline), and their configuration. Additionally, core testing dependencies like mocha, sinon, and c8 are being removed. If unit tests are intended to remain, they should be preserved along with their dependencies and configuration.
core/generator/gapic-generator-typescript/baselines/compute-esm/.eslintignore.baseline (9)
There is an inconsistency in the compute-esm baseline. While unit test references are removed from .eslintignore (line 9) and system test files are deleted, the unit test files themselves are not included in the removal patches, and the package.json and tsconfig.json for this baseline are missing from the PR. This baseline should be updated consistently with the others if the goal is to remove all tests.
This reverts commit b2fc1e9.
…m/googleapis/google-cloud-node into remove-the-system-tests-generator
Description
This change addresses issue #8017. It removes the system tests from the generator which is necessary because the system tests are unhelpful.
Impact
Summary for the reviewer
You'll notice this PR is large, but that is just because of the final
npm run baselinecommand used to generate the baseline file changes. It will be a lot easier to review the changes before running that command at main...ab6beac to evaluate correctness.These changes include: