Skip to content

fix: add cyrptography package to prerelease tests #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
parthea wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: add cyrptography package to prerelease tests #2513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions gapic/templates/noxfile.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,9 @@ def prerelease_deps(session, protobuf_implementation):
f"import {version_namespace}; print({version_namespace}.__version__)",
)

# Required by google-auth v3.x
session.install("cryptography")

session.run(
"py.test",
"tests/unit",
Expand Down Expand Up @@ -602,6 +605,9 @@ def core_deps_from_source(session, protobuf_implementation):
session.install(dep, "--no-deps", "--ignore-installed")
print(f"Installed {dep}")

# Required by google-auth v3.x
session.install("cryptography")

session.run(
"py.test",
"tests/unit",
Expand Down
6 changes: 6 additions & 0 deletions tests/integration/goldens/asset/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,9 @@ def prerelease_deps(session, protobuf_implementation):
f"import {version_namespace}; print({version_namespace}.__version__)",
)

# Required by google-auth v3.x
session.install("cryptography")

session.run(
"py.test",
"tests/unit",
Expand Down Expand Up @@ -596,6 +599,9 @@ def core_deps_from_source(session, protobuf_implementation):
session.install(dep, "--no-deps", "--ignore-installed")
print(f"Installed {dep}")

# Required by google-auth v3.x
session.install("cryptography")

session.run(
"py.test",
"tests/unit",
Expand Down
6 changes: 6 additions & 0 deletions tests/integration/goldens/credentials/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,9 @@ def prerelease_deps(session, protobuf_implementation):
f"import {version_namespace}; print({version_namespace}.__version__)",
)

# Required by google-auth v3.x
session.install("cryptography")

session.run(
"py.test",
"tests/unit",
Expand Down Expand Up @@ -596,6 +599,9 @@ def core_deps_from_source(session, protobuf_implementation):
session.install(dep, "--no-deps", "--ignore-installed")
print(f"Installed {dep}")

# Required by google-auth v3.x
session.install("cryptography")

session.run(
"py.test",
"tests/unit",
Expand Down
6 changes: 6 additions & 0 deletions tests/integration/goldens/eventarc/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,9 @@ def prerelease_deps(session, protobuf_implementation):
f"import {version_namespace}; print({version_namespace}.__version__)",
)

# Required by google-auth v3.x
session.install("cryptography")

session.run(
"py.test",
"tests/unit",
Expand Down Expand Up @@ -596,6 +599,9 @@ def core_deps_from_source(session, protobuf_implementation):
session.install(dep, "--no-deps", "--ignore-installed")
print(f"Installed {dep}")

# Required by google-auth v3.x
session.install("cryptography")

session.run(
"py.test",
"tests/unit",
Expand Down
6 changes: 6 additions & 0 deletions tests/integration/goldens/logging/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,9 @@ def prerelease_deps(session, protobuf_implementation):
f"import {version_namespace}; print({version_namespace}.__version__)",
)

# Required by google-auth v3.x
session.install("cryptography")

session.run(
"py.test",
"tests/unit",
Expand Down Expand Up @@ -596,6 +599,9 @@ def core_deps_from_source(session, protobuf_implementation):
session.install(dep, "--no-deps", "--ignore-installed")
print(f"Installed {dep}")

# Required by google-auth v3.x
session.install("cryptography")

session.run(
"py.test",
"tests/unit",
Expand Down
6 changes: 6 additions & 0 deletions tests/integration/goldens/logging_internal/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,9 @@ def prerelease_deps(session, protobuf_implementation):
f"import {version_namespace}; print({version_namespace}.__version__)",
)

# Required by google-auth v3.x
session.install("cryptography")
Copy link
Contributor

@daniel-sanche daniel-sanche Dec 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure it makes sense to install this as a new session.install step?

It seems like there should already be lists of dependencies. Maybe it could be added to prerel_deps or UNIT_TEST_STANDARD_DEPENDENCIES or a constraints file or something?


session.run(
"py.test",
"tests/unit",
Expand Down Expand Up @@ -596,6 +599,9 @@ def core_deps_from_source(session, protobuf_implementation):
session.install(dep, "--no-deps", "--ignore-installed")
print(f"Installed {dep}")

# Required by google-auth v3.x
session.install("cryptography")

session.run(
"py.test",
"tests/unit",
Expand Down
6 changes: 6 additions & 0 deletions tests/integration/goldens/redis/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,9 @@ def prerelease_deps(session, protobuf_implementation):
f"import {version_namespace}; print({version_namespace}.__version__)",
)

# Required by google-auth v3.x
session.install("cryptography")

session.run(
"py.test",
"tests/unit",
Expand Down Expand Up @@ -596,6 +599,9 @@ def core_deps_from_source(session, protobuf_implementation):
session.install(dep, "--no-deps", "--ignore-installed")
print(f"Installed {dep}")

# Required by google-auth v3.x
session.install("cryptography")

session.run(
"py.test",
"tests/unit",
Expand Down
6 changes: 6 additions & 0 deletions tests/integration/goldens/redis_selective/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,9 @@ def prerelease_deps(session, protobuf_implementation):
f"import {version_namespace}; print({version_namespace}.__version__)",
)

# Required by google-auth v3.x
session.install("cryptography")

session.run(
"py.test",
"tests/unit",
Expand Down Expand Up @@ -596,6 +599,9 @@ def core_deps_from_source(session, protobuf_implementation):
session.install(dep, "--no-deps", "--ignore-installed")
print(f"Installed {dep}")

# Required by google-auth v3.x
session.install("cryptography")

session.run(
"py.test",
"tests/unit",
Expand Down
Loading