fix: add cyrptography package to prerelease tests

[parthea]

Cryptography is a required dependency of google-auth 3.x pre-release and needs to be added to the pre-release tests since we install dependencies with --no-deps.

gapic-generator-python/gapic/templates/noxfile.py.j2

Line 508 in d20dd28

session.install("--pre", "--no-deps", "--ignore-installed", dep)

The reason for using --no-deps is to ensure that a pre-release version of a package is not downgraded.

[gemini-code-assist]

Summary of Changes

Hello @parthea, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a potential issue with prerelease test failures by incorporating the cryptography package into the test environment setup. The cryptography library is a required dependency for google-auth v3.x, and its explicit inclusion in both the dependency list and the installation process for core dependencies will ensure that tests run smoothly and reliably.

Highlights

• Prerelease Dependencies: The "cryptography" package has been added to the list of prerelease dependencies (prerel_deps) in noxfile.py.j2. This ensures it's available for testing environments.
• Test Session Installation: Explicit installation of the cryptography package has been added to the core_deps_from_source session within noxfile.py.j2. This guarantees its presence before running unit tests, specifically for google-auth v3.x compatibility.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to add the cryptography package as a dependency for prerelease tests, as it's required by google-auth v3.x. The changes correctly add it to the prerel_deps list. However, in the core_deps_from_source session, cryptography is installed as an undefined variable instead of a string literal, which will cause the session to fail. I've provided a suggestion to fix this critical issue.

[daniel-sanche]

Are you sure it makes sense to install this as a new session.install step?

It seems like there should already be lists of dependencies. Maybe it could be added to prerel_deps or UNIT_TEST_STANDARD_DEPENDENCIES or a constraints file or something?

[daniel-sanche]

The reason for using --no-deps is to ensure that a pre-release version of a package is not downgraded.

It sounds like using --upgrade-strategy eager might be another way to accomplish the same thing, without losing dependency download. But I'm not super familiar with this, so maybe I'm misunderstanding