Skip to content

Add missing dependencies to fix test failures #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nan-yu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing dependencies to fix test failures #513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion a2a_agents/python/a2ui_extension/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@ version = "0.1.0"
description = "A2UI Extension"
readme = "README.md"
requires-python = ">=3.10"
dependencies = ["a2a-sdk>=0.3.0"]
dependencies = [
"a2a-sdk>=0.3.0",
"google-adk>=1.8.0",
"google-genai>=1.27.0",
"jsonschema>=4.0.0"
Comment on lines +9 to +11
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider adding an upper bound to these external dependencies. Using only >= can lead to unexpected breaking changes if a new major version is released. Specifying an upper bound (e.g., <2.0.0 for google-adk and google-genai, <5.0.0 for jsonschema) or using the compatible release operator (~=) can provide more stability and prevent potential issues with future releases.

Suggested change
"google-adk>=1.8.0",
"google-genai>=1.27.0",
"jsonschema>=4.0.0"
"google-adk>=1.8.0,<2.0.0",
"google-genai>=1.27.0,<2.0.0",
"jsonschema>=4.0.0,<5.0.0"

]

[build-system]
requires = ["hatchling"]
Expand All @@ -29,3 +34,8 @@ pyink-annotation-pragmas = [
"pyre-",
]

[dependency-groups]
dev = [
"pytest>=9.0.2",
"pytest-asyncio>=1.3.0",
Comment on lines +39 to +40
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the main dependencies, it's a good practice to add an upper bound to development dependencies like pytest and pytest-asyncio. This helps prevent unexpected major version upgrades that might introduce breaking changes to your test suite. For example, pytest>=9.0.2,<10.0.0.

Suggested change
"pytest>=9.0.2",
"pytest-asyncio>=1.3.0",
"pytest>=9.0.2,<10.0.0",
"pytest-asyncio>=1.3.0,<2.0.0",

]
Loading
Loading