Add missing dependencies to fix test failures #513
Conversation
`uv run --with pytest pytest tests/test_send_a2ui_to_client_toolset.py` currently fails due to missing dependencies. This commit updates the project configurations to fix the test failures.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request effectively addresses the issue of missing dependencies by updating the pyproject.toml file. The addition of google-adk, google-genai, and jsonschema to the main dependencies, and pytest and pytest-asyncio to a new dev dependency group, correctly resolves the reported test failures. The PR description also includes a completed pre-launch checklist, which is a good practice.
| "google-adk>=1.8.0", | ||
| "google-genai>=1.27.0", | ||
| "jsonschema>=4.0.0" |
There was a problem hiding this comment.
Consider adding an upper bound to these external dependencies. Using only >= can lead to unexpected breaking changes if a new major version is released. Specifying an upper bound (e.g., <2.0.0 for google-adk and google-genai, <5.0.0 for jsonschema) or using the compatible release operator (~=) can provide more stability and prevent potential issues with future releases.
| "google-adk>=1.8.0", | |
| "google-genai>=1.27.0", | |
| "jsonschema>=4.0.0" | |
| "google-adk>=1.8.0,<2.0.0", | |
| "google-genai>=1.27.0,<2.0.0", | |
| "jsonschema>=4.0.0,<5.0.0" |
| "pytest>=9.0.2", | ||
| "pytest-asyncio>=1.3.0", |
There was a problem hiding this comment.
Similar to the main dependencies, it's a good practice to add an upper bound to development dependencies like pytest and pytest-asyncio. This helps prevent unexpected major version upgrades that might introduce breaking changes to your test suite. For example, pytest>=9.0.2,<10.0.0.
| "pytest>=9.0.2", | |
| "pytest-asyncio>=1.3.0", | |
| "pytest>=9.0.2,<10.0.0", | |
| "pytest-asyncio>=1.3.0,<2.0.0", |
1 participant
uv run --with pytest pytest tests/test_send_a2ui_to_client_toolset.pycurrently fails due to missing dependencies. This commit updates the project configurations to fix the test failures.Description
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.