Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
kevinzakka
left a comment
kevinzakka
left a comment
There was a problem hiding this comment.
Thanks for your contribution @apirrone! I left some comments.
| @@ -0,0 +1,19 @@ | |||
| # Open Duck Mini V2 | |||
| @@ -0,0 +1,454 @@ | |||
| <mujoco model="onshape"> | |||
There was a problem hiding this comment.
Can you do some minimal formatting on this onshape generated XML? We have some instructions here.
| </contact> | ||
| <worldbody> | ||
| <body name="base" pos="0 0 0.22"> | ||
| <!-- <body name="base" pos="0 0 0.4"> --> |
There was a problem hiding this comment.
Nit: Remove comments please.
| rgba="0.223529 0.219608 0.219608 1" mesh="left_knee_to_ankle_right_sheet"/> | ||
| <geom pos="0.01606 0.14365 0.10915" quat="0.707107 -0.707107 0 0" type="mesh" | ||
| rgba="0.223529 0.219608 0.219608 1" mesh="left_knee_to_ankle_left_sheet"/> | ||
| <geom pos="0 -0.05315 0.00955" quat="0.5 -0.5 -0.5 0.5" type="mesh" rgba="0.247059 0.243137 0.243137 1" |
There was a problem hiding this comment.
I'd prefer if rgbas were converted to materials and material names used instead.
|
Hi @kevinzakka, thanks for the comments ! I actually have a question : The mjcf I added here is a heavily decimated and simplified version intended to be efficient for mjx, but I can also export a pretty one with all the geometry and features. Which one makes most sense to publish here? Can I upload both ? Thanks ! |
|
Yes making both is fine. Note visual geometry should not affect MJX performance if you are using primitive geoms for the colliders. |
2 participants
Adds mjcf description for Open Duck Mini v2