Skip to content

Fix didPanic to use type assertion for runtime.PanicNilError instead of string comparison #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredbi merged 2 commits into from
Jun 18, 2026
+3 −4
Merged

Fix didPanic to use type assertion for runtime.PanicNilError instead of string comparison #124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6764712
Initial plan
Copilot Jun 18, 2026
15fd903
fix: use runtime.PanicNilError type assertion instead of error string…
Copilot Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions internal/assertions/panic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package assertions

import (
"fmt"
"runtime"
"runtime/debug"
)

Expand Down Expand Up @@ -133,10 +134,8 @@ func didPanic(f func()) (didPanic bool, message any, stack string) {
}
// Go 1.21 introduces runtime.PanicNilError on panic(nil),
// so maintain the same logic going forward (https://github.com/golang/go/issues/25448).
if err, ok := message.(error); ok {
if err.Error() == "panic called with nil argument" {
message = nil
}
if _, ok := message.(*runtime.PanicNilError); ok {
message = nil
}
}()

Expand Down
Loading