Fix didPanic to use type assertion for runtime.PanicNilError instead of string comparison#124
Merged
Merged
Conversation
… comparison The didPanic function previously checked for runtime.PanicNilError by comparing the Error() string "panic called with nil argument". This breaks in Go 1.27 where the error message changes. Use a direct type assertion for *runtime.PanicNilError instead, which is the stable API and works across all Go versions from 1.21 onward. Closes #123 Signed-off-by: GitHub Copilot <copilot@github.com>
Copilot
AI
changed the title
[WIP] Fix didPanic to handle Go 1.27 panic error string changes
Fix didPanic to use type assertion for runtime.PanicNilError instead of string comparison
Jun 18, 2026
fredbi
approved these changes
Jun 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #124 +/- ##
==========================================
+ Coverage 91.68% 91.69% +0.01%
==========================================
Files 97 97
Lines 12602 12601 -1
==========================================
+ Hits 11554 11555 +1
+ Misses 826 825 -1
+ Partials 222 221 -1 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
didPanicdetectspanic(nil)by comparingerr.Error() == "panic called with nil argument". Go 1.27 changes this error string (golang/go#63813, CL 791540), breaking the check.*runtime.PanicNilErrortype assertion, which is the stable API available since Go 1.21