fix: do not consume request body unless explicitly requested#68
Open
techfg wants to merge 1 commit intogo-chi:masterfrom
Open
fix: do not consume request body unless explicitly requested#68techfg wants to merge 1 commit intogo-chi:masterfrom
techfg wants to merge 1 commit intogo-chi:masterfrom
Conversation
This was referenced Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new option
LogAdditionalAttrsand deprecatesLogExtraAttrs:LogAdditionalAttrsOptions.IncludeRequestBodyto provide control over when request body is consumed and passed toLogAdditionalAttrsOptions.AdditionalAttrs. The default isfalse(vs.LogExtraAttrswhich would always consume the entire body) which could lead to high memory usage even when not neededLogDetailstoLogAdditionalAttrsOptions.AdditionalAttrswhich contains the same params asLogExtraAttrsdoes but supports extending additional details if/when needed to avoid breaking changes moving forwardThe approach taken is not a breaking change, however if desired, the implementation can be simplified which would result in a breaking change and a major bump.
Resolves #62