feat: add ResponseBytes and RequestBytesUnread to LogAdditionalAttrsOptions.AdditionalAttrs#69
Open
techfg wants to merge 2 commits intogo-chi:masterfrom
Open
feat: add ResponseBytes and RequestBytesUnread to LogAdditionalAttrsOptions.AdditionalAttrs#69techfg wants to merge 2 commits intogo-chi:masterfrom
ResponseBytes and RequestBytesUnread to LogAdditionalAttrsOptions.AdditionalAttrs#69techfg wants to merge 2 commits intogo-chi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR assumes #68 is merged. If #68 is not merged, the signature to
LogExtraAttrswould need to change to pass this information through. PR #68 introduces a non-breaking change that allows adding additional information moving forward without requiring breaking changes.Adds passing
ResponseBytesandRequestBytesUnreadtoLogAdditionalAttrsOptions.AdditionalAttrs.Note - A similar thing can/should be done for RequestBytesRead assuming PR #67 is merged.
Resolves #63