Skip to content

Implementation of method for adding new events incrementally.#10

Closed
apiss2 wants to merge 3 commits intoglandfried:masterfrom
apiss2:AddingEventsIncrementally
Closed

Implementation of method for adding new events incrementally.#10
apiss2 wants to merge 3 commits intoglandfried:masterfrom
apiss2:AddingEventsIncrementally

Conversation

@apiss2
Copy link

@apiss2 apiss2 commented May 25, 2024

I have separated the addition process of competitions into the add_history method. This modification allows for incremental addition of competitions.

The existing interface remains unchanged.

To prevent inappropriate updating of last_time in agents, each newly added competition is compared with the min(times) of all previously added competitions. This check ensures that every newly added competition occurs after all competitions added prior to it.

Do we need to create new tests for this feature?

Thank you for your review!

@glandfried
Copy link
Owner

Hi, I add a basic test to your branch for the proposed add_history method. You are relying on the trueskill method, that only serves at the first time. I recommend no touching it. Instead, there is an old unfinished method to add new events, called add_events. Maybe you can finish it. Below the new test you will see a commented test for add_events.

@glandfried
Copy link
Owner

@glandfried
Copy link
Owner

Pull Request V2.0.0

@apiss2
Copy link
Author

apiss2 commented Nov 21, 2025

I'm sorry that I haven't been able to contribute for a while.
However, I'm delighted to hear that version 2.0.0—which includes the points discussed in this issue—is scheduled for release.
I’ve reviewed the content, and I think it looks excellent!
I’ve also created a #14 so that I can contribute even a little.
I'm looking forward to the release of version 2.0.0.
Thank you in advance.

@apiss2 apiss2 closed this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants