Complete implementation of add_events for incremental updates#12
Open
korentomas wants to merge 4 commits intoglandfried:masterfrom
Open
Complete implementation of add_events for incremental updates#12korentomas wants to merge 4 commits intoglandfried:masterfrom
korentomas wants to merge 4 commits intoglandfried:masterfrom
Conversation
Owner
|
Nice to see you here! I’ll review the code this week. If you’re interested, I can show you a new version of the code that it’s simpler, cleaner, and includes new capabilities for handling discrete observables (such as goals). |
Owner
|
We have a new version v2.0.0 in: |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi @glandfried! How have you been doing? I am going to try using TTT in practice. This PR completes the implementation of the
add_eventsmethod in Python, enabling incremental updates to History objects without recomputing from scratch.Motivation
As discussed in PR #10, the ability to add events incrementally is essential. The previous attempt relied on the
trueskill()method which "only serves at the first time". This implementation follows the pattern from the Julia version which handles message passing correctly.Changes
Batch.add_events()(was checkingif a in b.skills, should beif a not in b.skills)History.add_events()with proper message passingTesting
All new functionality is covered by tests. The implementation follows the same logic as the working Julia version.
Co-authored by @apiss2