Skip to content

dev(rspack): Add SENTRY_DEVSERVER_NGROK to dev server "allowed hosts" #107801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
billyvg wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Open

dev(rspack): Add SENTRY_DEVSERVER_NGROK to dev server "allowed hosts" #107801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions rspack.config.ts
View file
Open in desktop
Copy link
Member Author

@billyvg billyvg Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prob should throw this in CODEOWNERS if we want to keep the owners-js-build team

Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ const SENTRY_BACKEND_PORT = env.SENTRY_BACKEND_PORT;
const SENTRY_WEBPACK_PROXY_HOST = env.SENTRY_WEBPACK_PROXY_HOST;
const SENTRY_WEBPACK_PROXY_PORT = env.SENTRY_WEBPACK_PROXY_PORT;
const SENTRY_RELEASE_VERSION = env.SENTRY_RELEASE_VERSION;
const SENTRY_DEVSERVER_NGROK = env.SENTRY_DEVSERVER_NGROK;

// Used by sentry devserver runner to force using webpack-dev-server
const FORCE_WEBPACK_DEV_SERVER = !!env.FORCE_WEBPACK_DEV_SERVER;
Expand Down Expand Up @@ -307,8 +308,10 @@ const appConfig: Configuration = {
test: /\.(js|jsx|ts|tsx)$/,
// Avoids recompiling core-js based on usage imports
exclude: /node_modules[\\/]core-js/,
loader: 'builtin:swc-loader',
options: swcReactLoaderConfig,
use: [
{loader: 'builtin:swc-loader', options: swcReactLoaderConfig},
// {loader: 'babel-loader'},
Copy link
Contributor

@cursor cursor bot Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out babel-loader appears accidentally committed

Low Severity

The PR description states this change is only about adding SENTRY_DEVSERVER_NGROK to allowed hosts, but it also includes an unrelated change to the JS/TS loader configuration. The loader syntax was converted from direct loader/options properties to a use array, and a commented-out // {loader: 'babel-loader'} line was left behind. This appears to be leftover testing code that was accidentally included in the commit.

Fix in Cursor Fix in Web

],
},
{
test: /\.mdx?$/,
Expand Down Expand Up @@ -645,6 +648,9 @@ if (
// SEO: ngrok, hot reload, SENTRY_UI_HOT_RELOAD. Uncomment this to allow hot-reloading when using ngrok. This is disabled by default
// since ngrok urls are public and can be accessed by anyone.
// '.ngrok.io',

// Needed if you want to use ngrok w/ backend
...(SENTRY_DEVSERVER_NGROK ? [`.${SENTRY_DEVSERVER_NGROK}`] : []),
],
static: {
directory: './src/sentry/static/sentry',
Expand Down
Loading