dev(rspack): Add SENTRY_DEVSERVER_NGROK to dev server "allowed hosts"#107801
dev(rspack): Add SENTRY_DEVSERVER_NGROK to dev server "allowed hosts"#107801
SENTRY_DEVSERVER_NGROK to dev server "allowed hosts"#107801Conversation
The backend devserver uses `SENTRY_DEVSERVER_NGROK` to its ALLOWED_HOSTS, rspack needs to do the same so we can avoid manual changes
github-actions
bot
added
the
Scope: Frontend
There was a problem hiding this comment.
prob should throw this in CODEOWNERS if we want to keep the owners-js-build team
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| options: swcReactLoaderConfig, | ||
| use: [ | ||
| {loader: 'builtin:swc-loader', options: swcReactLoaderConfig}, | ||
| // {loader: 'babel-loader'}, |
There was a problem hiding this comment.
Commented out babel-loader appears accidentally committed
Low Severity
The PR description states this change is only about adding SENTRY_DEVSERVER_NGROK to allowed hosts, but it also includes an unrelated change to the JS/TS loader configuration. The loader syntax was converted from direct loader/options properties to a use array, and a commented-out // {loader: 'babel-loader'} line was left behind. This appears to be leftover testing code that was accidentally included in the commit.
1 participant
The backend devserver uses
SENTRY_DEVSERVER_NGROKto its ALLOWED_HOSTS, rspack needs to do the same so we can avoid manual changes