fix(typing): Use subscript access for required event_id in delayed_processing#107792
Draft
fix(typing): Use subscript access for required event_id in delayed_processing#107792
Conversation
github-actions
bot
added
the
Scope: Backend
…ocessing `event_id` is a required key in `EventData` TypedDict, so use `instance_data["event_id"]` instead of `.get()`. Remove the dead None-check branch since it can never be reached. Ref: #107727
JoshFerge
force-pushed
the
jferg/fix-typing-delayed-processing
branch
from
6fde08e to
e800221
Compare
JoshFerge
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
instance_data["event_id"]subscript access instead of.get()sinceevent_idis a required key in theEventDataTypedDictif event_id is Nonebranch that could never be reachedRef: #107710