Skip to content

Commit e800221

Browse files
committed
fix(typing): Use subscript access for required event_id in delayed_processing
`event_id` is a required key in `EventData` TypedDict, so use `instance_data["event_id"]` instead of `.get()`. Remove the dead None-check branch since it can never be reached. Ref: #107727
1 parent abcaf47 commit e800221

1 file changed

Lines changed: 1 addition & 8 deletions

File tree

src/sentry/rules/processing/delayed_processing.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -296,17 +296,10 @@ def build_group_to_groupevent(
296296
group_to_groupevent: dict[Group, tuple[GroupEvent, datetime | None]] = {}
297297

298298
for rule_group, instance_data in parsed_rulegroup_to_event_data.items():
299-
event_id = instance_data.get("event_id")
299+
event_id = instance_data["event_id"]
300300
occurrence_id = instance_data.get("occurrence_id")
301301
start_timestamp = instance_data.get("start_timestamp")
302302

303-
if event_id is None:
304-
logger.info(
305-
"delayed_processing.missing_event_id",
306-
extra={"rule": rule_group[0], "project_id": project_id},
307-
)
308-
continue
309-
310303
event = bulk_event_id_to_events.get(event_id)
311304
group = group_id_to_group.get(int(rule_group[1]))
312305

0 commit comments

Comments
 (0)