ref(ci): Skip PR review reminders for changes-requested PRs#21526
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 962cdb5. Configure here.
The review-reminder job already skips draft PRs, bot PRs, and approved PRs. Also skip PRs that have an *outstanding* "changes requested" review: in that state the PR is waiting on the author, so nagging the reviewers is just noise. Change-requests from reviewers who were re-requested (and so are back in the pending-reviewer list) are ignored, so the author re-requesting a review still results in reminders. Dismissed reviews report state `DISMISSED`, so they no longer count either. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
force-pushed
the
feat/pr-reminder-skip-changes-requested
branch
from
962cdb5 to
602ee85
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adjusts the PR review-reminder job (
scripts/pr-review-reminder.mjs) so it stops pinging reviewers on PRs that are blocked on the author.if (pr.draft) continue;) — no change needed, documented for clarity.Handling re-requests correctly
A change-request only suppresses reminders while it's still outstanding. When the author addresses the feedback and re-requests a review, that reviewer reappears in
listRequestedReviewers(the pending list), which supersedes their earlier change-request — so we ignore change-requests from currently-pending reviewers and they keep getting reminded. Dismissed reviews report stateDISMISSED(notCHANGES_REQUESTED), so they don't count either.