Commit 1d74cc0
ref(ci): Skip PR review reminders for changes-requested PRs (#21526)
## Summary
Adjusts the PR review-reminder job (`scripts/pr-review-reminder.mjs`) so
it stops pinging reviewers on PRs that are blocked on the author.
- **Draft PRs** are **already** ignored (`if (pr.draft) continue;`) — no
change needed, documented for clarity.
- **New:** skip PRs that have an **outstanding "changes requested"**
review. In that state the ball is in the author's court, so nagging the
reviewers is just noise. This mirrors the existing "skip if already
approved" guard.
### Handling re-requests correctly
A change-request only suppresses reminders while it's still outstanding.
When the author addresses the feedback and **re-requests** a review,
that reviewer reappears in `listRequestedReviewers` (the pending list),
which supersedes their earlier change-request — so we ignore
change-requests from currently-pending reviewers and they keep getting
reminded. Dismissed reviews report state `DISMISSED` (not
`CHANGES_REQUESTED`), so they don't count either.
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 5da0cc9 commit 1d74cc0
1 file changed
Lines changed: 21 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
8 | 12 | | |
9 | 13 | | |
10 | 14 | | |
| |||
179 | 183 | | |
180 | 184 | | |
181 | 185 | | |
182 | | - | |
183 | 186 | | |
184 | 187 | | |
185 | 188 | | |
186 | 189 | | |
187 | 190 | | |
188 | 191 | | |
| 192 | + | |
| 193 | + | |
189 | 194 | | |
190 | 195 | | |
191 | 196 | | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
192 | 212 | | |
193 | 213 | | |
194 | 214 | | |
| |||
0 commit comments