Skip to content

Add rfl::Commented, resolves #597 #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liuzicheng1987 wants to merge 1 commit into from
Closed

Add rfl::Commented, resolves #597 #601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions include/rfl/parsing/ViewReader.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,7 @@ class ViewReader {
if (!already_assigned) {
std::stringstream stream;
stream << "Value named '" << _current_name_or_index
<< "' not used. Remove the rfl::NoExtraFields processor or add "
"rfl::ExtraFields to avoid this error message.";
<< "' not used.";
Copy link

@gemini-code-assist gemini-code-assist bot Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change makes the error message less helpful by removing the proposed solutions for the user. The previous message explained that rfl::NoExtraFields was active and suggested either removing it or adding rfl::ExtraFields to the struct. This guidance is very useful for developers using the library.

Please consider restoring this part of the error message. If rfl::Commented (as mentioned in the PR title) provides another alternative, it would be beneficial to include that in the message as well.

Suggested change
<< "' not used.";
<< "' not used. Remove the rfl::NoExtraFields processor or add rfl::ExtraFields to avoid this error message.";

_errors->emplace_back(Error(stream.str()));
}
}
Expand Down
Loading