Add rfl::Commented, resolves #597

[liuzicheng1987]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @liuzicheng1987, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the rfl::Commented feature, addressing issue #597. The current patch focuses on a minor but impactful change within the ViewReader.hpp file, where an existing error message has been made more concise and less prescriptive regarding potential solutions.

Highlights

• Error Message Refinement: The error message displayed when an unused value is encountered in ViewReader.hpp has been simplified. The message no longer suggests specific processors like rfl::NoExtraFields or rfl::ExtraFields.

Changelog

• include/rfl/parsing/ViewReader.hpp
  • Simplified the error message for unused values by removing specific suggestions for rfl::NoExtraFields or rfl::ExtraFields.

Activity

• No specific activity (comments, reviews, approvals) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request simplifies an error message in ViewReader.hpp. However, the change removes helpful guidance for the user on how to resolve the error. My review includes a suggestion to restore the helpful information in the error message to improve the developer experience.

[gemini-code-assist]

This change makes the error message less helpful by removing the proposed solutions for the user. The previous message explained that rfl::NoExtraFields was active and suggested either removing it or adding rfl::ExtraFields to the struct. This guidance is very useful for developers using the library.

Please consider restoring this part of the error message. If rfl::Commented (as mentioned in the PR title) provides another alternative, it would be beneficial to include that in the message as well.

Suggested change

	<< "' not used.";
	<< "' not used. Remove the rfl::NoExtraFields processor or add rfl::ExtraFields to avoid this error message.";