fix(connectors): wrap fetch transport failures in the typed error class#155
Merged
Conversation
gh/gd/gdText only wrapped non-2xx responses; a fetch() rejection (DNS, timeout, offline) escaped as a raw TypeError. Each fetch call site now rethrows transport failures as GitHubError/GoogleDriveError with status 0. Closes #148
suleimansh
added
bug
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #148.
gh/gd/gdTextonly wrapped non-2xx responses inGitHubError/GoogleDriveError. Afetch()rejection (DNS failure, timeout, offline) escaped as a rawTypeError, so callers couldn't handle transport failures through the same typed class.Each
fetchcall site is now routed through a smallghFetch/gdFetchhelper that rethrows transport failures as the connector's error type withstatus: 0.Tests: one transport-failure test per connector asserting
instanceof <Error>,status === 0, and anetwork errormessage.pnpm typecheck+pnpm testgreen (github 8, drive 12). Patch changeset for both connectors.Disjoint from #146/#147 (touches only
client.ts).