fix(connectors): aggregate per-connector instructions into server metadata#152
Merged
Conversation
…adata mountConnectors only read the server-level instructions option and never consumed Connector.instructions, so per-connector instructions set via defineConnector were silently dropped. Compose them into the server instructions: server-level text first, then each connector's text under a heading named after the connector. Closes #146
suleimansh
added
bug
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #146.
mountConnectorsonly read the server-levelinstructionsoption and never consumedConnector.instructions, so per-connector instructions set viadefineConnectorwere silently dropped — including in both reference connectors (connector-github,connector-google-drive), the code third parties copy.Now a
composeInstructionshelper combines them: server-level text first, then each connector's text under a## <name>heading so the agent knows which tools it applies to. Omitted entirely when nothing sets instructions.Three new kit tests cover aggregation, server-level ordering, and the empty case.
pnpm typecheck+pnpm test(11/11) green. Patch changeset included.