Better differentiate between commit ID and version for GL canonical name #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
NotTheEvilOne
force-pushed
the
feature/improve-cname-parser-version-commit-id-handling
branch
from
1ed34fb to
4e6b03f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
+ Coverage 90.86% 91.08% +0.22%
==========================================
Files 27 27
Lines 1226 1234 +8
==========================================
+ Hits 1114 1124 +10
+ Misses 112 110 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
NotTheEvilOne
deleted the
feature/improve-cname-parser-version-commit-id-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR improves handling of commit ID and version for the GardenLinux canonical name. Both input and output differentiate between
commitandversionwhile for input<version>-<commit>can be used forversionin cases parsing and splitting is difficult.Which issue(s) this PR fixes:
Related gardenlinux/builder#115