-
Notifications
You must be signed in to change notification settings - Fork 3
Unify python-gardenlinux-lib based feature and cname parsing
#115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
NotTheEvilOne
wants to merge
1
commit into
main
Choose a base branch
from
feature/python-lib-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6423af1 to
794f3bd
Compare
794f3bd to
2fbc117
Compare
2fbc117 to
8b2977a
Compare
nkraetzschmar
requested changes
Aug 1, 2025
Contributor
|
We should consider how this relates to the following issues and maybe resolve those first, before we proceed here |
14a5837 to
12e7f2b
Compare
12e7f2b to
5f11648
Compare
5f11648 to
4ed9d3d
Compare
4ed9d3d to
42e4630
Compare
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
42e4630 to
7cee5d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently
builder/parse_featuresprovides duplicated code and features withpython-gardenlinux-libto parse and return information about GardenLinux features, flavors and canonical names. To unify and ensure code quality this PR replaces it with the CLI utilities ofpython-gardenlinux-lib.Which issue(s) this PR fixes:
Related gardenlinux/python-gardenlinux-lib#129