Skip to content

Fix quadratic-time linebreak parsing #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
absolutely-vivid wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix quadratic-time linebreak parsing #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions marko/inline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,16 @@ def __init__(self, match: _Match) -> None:
self.soft = not match.group(1).startswith((" ", "\\"))
self.children = "\n"

@classmethod
def find(cls, text: str, *, source: Source) -> Iterator[_Match]:
"""This method should return an iterable containing matches of this element."""
# HACK: short circuit to avoid quadratic runtime when text doesn't have a linebreak.
# ideally the regex pattern should be rewritten, but this works for now.
# see issue #219
if '\n' not in text:
return []
return super().find(text, source=source)


class InlineHTML(InlineElement):
priority = 7
Expand Down
Loading