Fix quadratic-time linebreak parsing#268
Open
absolutely-vivid wants to merge 1 commit into
Open
Conversation
This is a quick hack to fix issue frostming#219. The regex pattern used for parsing linebreaks combined with the use of `re.finditer` runs in quadratic time when the parsing input doesn't contain a newline character. By checking for the presence of a newline character the problematic pattern can be short-circuited. Ideally a proper fix would fix the regex pattern itself, but this is a useful fix to have in place until the pattern is fixed. Fixes frostming#219
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick hack to fix issue #219. The regex pattern used for parsing linebreaks combined with the use of
re.finditerruns in quadratic time when the parsing input doesn't contain a newline character. By checking for the presence of a newline character the problematic pattern can be short-circuited. Ideally a proper fix would fix the regex pattern itself, but this is a useful fix to have in place until the pattern is fixed.Fixes #219