Skip to content

fix: TypeError: Cannot read properties of null (reading 'classList') #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akhilnarang wants to merge 1 commit into from
Closed

fix: TypeError: Cannot read properties of null (reading 'classList') #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/cellmanager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,8 +391,11 @@ export default class CellManager {

clearSelection() {
(this._selectedCells || [])
.forEach($cell => $cell.classList.remove('dt-cell--highlight'));

.forEach($cell => {
Copy link
Member

@ankush ankush Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem correct. The real problem is this array containing null... why does that happen?

if that root cause is harmless then fix is fine.

if ($cell && $cell.classList) {
$cell.classList.remove('dt-cell--highlight');
}
});
this._selectedCells = [];
this.$selectionCursor = null;
}
Expand Down