fix: TypeError: Cannot read properties of null (reading 'classList')#196
Closed
akhilnarang wants to merge 1 commit intofrappe:masterfrom
Closed
fix: TypeError: Cannot read properties of null (reading 'classList')#196akhilnarang wants to merge 1 commit intofrappe:masterfrom
akhilnarang wants to merge 1 commit intofrappe:masterfrom
Conversation
Sentry PRESS-4KJ / Support 10958 TypeError: Cannot read properties of null (reading 'classList') at ? (../../../../../apps/frappe/node_modules/frappe-datatable/dist/frappe-datatable.cjs.js:2940:37) at Array.forEach(<anonymous>) at Ye.clearSelection(../../../../../apps/frappe/node_modules/frappe-datatable/dist/frappe-datatable.cjs.js:2940:14) at Ye._selectArea(../../../../../apps/frappe/node_modules/frappe-datatable/dist/frappe-datatable.cjs.js:2877:14) at Ye.selectArea(../../../../../apps/frappe/node_modules/frappe-datatable/dist/frappe-datatable.cjs.js:2865:18) at HTMLDivElement.t(../../../../../apps/frappe/node_modules/frappe-datatable/dist/frappe-datatable.cjs.js:2723:18) at invokeFunc(../../../../../apps/frappe/node_modules/frappe-datatable/dist/frappe-datatable.cjs.js:632:19) at trailingEdge(../../../../../apps/frappe/node_modules/frappe-datatable/dist/frappe-datatable.cjs.js:681:14) at timerExpired(../../../../../apps/frappe/node_modules/frappe-datatable/dist/frappe-datatable.cjs.js:669:14) at r(../../../../../apps/frappe/node_modules/src/helpers.ts:98:1) Signed-off-by: Akhil Narang <me@akhilnarang.dev>
akhilnarang
force-pushed
the
fix-typeerror
branch
from
2090cb5 to
718838d
Compare
ankush
reviewed
Apr 17, 2024
| (this._selectedCells || []) | ||
| .forEach($cell => $cell.classList.remove('dt-cell--highlight')); | ||
|
|
||
| .forEach($cell => { |
Member
There was a problem hiding this comment.
Doesn't seem correct. The real problem is this array containing null... why does that happen?
if that root cause is harmless then fix is fine.
Member
|
The cause of this was when users sort the column and try selecting the cells (replicated it randomly one day) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sentry PRESS-4KJ / Support 10958
Not sure if this is "correct"