Skip to content

fix: in config benchmark add properties to the configs #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adityathebe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: in config benchmark add properties to the configs #2198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion bench/config_items_save_results_bench_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
v1 "github.com/flanksource/config-db/api/v1"
"github.com/flanksource/config-db/db"
dutyModels "github.com/flanksource/duty/models"
"github.com/flanksource/duty/types"
"github.com/google/uuid"
)

Expand Down Expand Up @@ -202,12 +203,29 @@ func buildScrapeResults(size int, dataset string, revision int) []v1.ScrapeResul
"port": 8080,
},
},
Properties: buildScrapeResultProperties(revision),
})
}

return results
}

func buildScrapeResultProperties(revision int) types.Properties {
payload := strings.Repeat("x", 16*1024)
properties := make(types.Properties, 0, 6)
for i := range 6 {
properties = append(properties, &types.Property{
Name: fmt.Sprintf("bench-property-%d", i),
Label: fmt.Sprintf("Bench Property %d", i),
Type: "text",
Text: fmt.Sprintf("%s-%d-%d", payload, revision, i),
Tooltip: fmt.Sprintf("bench property tooltip %d", i),
Order: i,
})
}
return properties
}

func cleanupBenchRows(tb testing.TB, scraperID uuid.UUID) {
tb.Helper()

Expand Down Expand Up @@ -243,4 +261,4 @@ func cleanupConfigChangesForBenchRows(tb testing.TB, scraperID uuid.UUID) {
).Error; err != nil {
tb.Fatalf("failed to cleanup config_changes: %v", err)
}
}
}
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ require (
github.com/flanksource/clicky v1.21.8
github.com/flanksource/commons v1.51.4
github.com/flanksource/deps v1.0.28
github.com/flanksource/duty v1.0.1301
github.com/flanksource/duty v1.0.1303-0.20260506141750-2f51bc8b0851
github.com/flanksource/gomplate/v3 v3.24.79
github.com/flanksource/is-healthy v1.0.87
github.com/flanksource/ketall v1.1.9
Expand Down
4 changes: 4 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,10 @@ github.com/flanksource/deps v1.0.28 h1:mm7l7WjzLbkj2aFrgnlMaRizp+j+0x22TvtwXzRlF
github.com/flanksource/deps v1.0.28/go.mod h1:2YRfP32WZrMxGVMYV51RlVHZfgerxf8DT3TqSgjzmTQ=
github.com/flanksource/duty v1.0.1301 h1:RfuBlJ5G+NMLR0erw4Y/axAzjM4Rr7YM151tljmWs3s=
github.com/flanksource/duty v1.0.1301/go.mod h1:aH4xdGF3brwBiOKUEFsspgu8U7tBiJOZDXrEqB3OMtc=
github.com/flanksource/duty v1.0.1302-0.20260505162206-080590b13191 h1:02ZfSQOdlGdj7Rfhncx6BaAjvuBcbTzAdvCV1ScOS50=
github.com/flanksource/duty v1.0.1302-0.20260505162206-080590b13191/go.mod h1:aH4xdGF3brwBiOKUEFsspgu8U7tBiJOZDXrEqB3OMtc=
github.com/flanksource/duty v1.0.1303-0.20260506141750-2f51bc8b0851 h1:fISszDBL2z0ypJQ2CKUQ4LlHbSDyI57+noVQskLLyEY=
github.com/flanksource/duty v1.0.1303-0.20260506141750-2f51bc8b0851/go.mod h1:aH4xdGF3brwBiOKUEFsspgu8U7tBiJOZDXrEqB3OMtc=
github.com/flanksource/gomplate/v3 v3.24.79 h1:T5Ls0tjsnDhcV/dQWjrm2UpHiwOhytDLmYDSF0O6p3Q=
github.com/flanksource/gomplate/v3 v3.24.79/go.mod h1:RzIg+YwNQI0eUV61LtqmhNN2Qw8ebm1cGa6IhNQmkWE=
github.com/flanksource/is-healthy v1.0.87 h1:wSK9wI9tu//gdKO9JxyZe8ZQ5H7MCpwG17KdbWaiMeM=
Expand Down
Loading