Skip to content

fix: in config benchmark add properties to the configs#2198

Open
adityathebe wants to merge 1 commit into
mainfrom
feat/config-properties-benchmark
Open

fix: in config benchmark add properties to the configs#2198
adityathebe wants to merge 1 commit into
mainfrom
feat/config-properties-benchmark

Conversation

@adityathebe
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Benchstat

Base: 71d2456e82ac5b60a79044c089e46ff115c3c7bb
Head: 3043d83b4618c29382f3b40ff8bc34396e9a05c2

✅ No significant performance changes detected

Full benchstat output
goos: linux
goarch: amd64
pkg: github.com/flanksource/config-db/bench
cpu: AMD EPYC 9V74 80-Core Processor                
                                         │ bench-base.txt │          bench-head.txt           │
                                         │     sec/op     │   sec/op     vs base              │
BenchSaveResultsSeed/N=1000-4                 3.606 ± 11%   3.560 ± 12%       ~ (p=0.937 n=6)
BenchSaveResultsUpdateUnchanged/N=1000-4      2.956 ±  1%   2.944 ±  7%       ~ (p=0.485 n=6)
BenchSaveResultsUpdateChanged/N=1000-4        6.948 ±  4%   6.938 ±  4%       ~ (p=0.485 n=6)
geomean                                       4.200         4.174        -0.61%

                                         │ bench-base.txt │           bench-head.txt           │
                                         │      MB/s      │    MB/s     vs base                │
BenchSaveResultsSeed/N=1000-4                0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
BenchSaveResultsUpdateUnchanged/N=1000-4     0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
BenchSaveResultsUpdateChanged/N=1000-4       0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                                 ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                         │ bench-base.txt │           bench-head.txt           │
                                         │      B/op      │     B/op      vs base              │
BenchSaveResultsSeed/N=1000-4                1.278Gi ± 0%   1.278Gi ± 0%       ~ (p=0.485 n=6)
BenchSaveResultsUpdateUnchanged/N=1000-4     32.31Mi ± 0%   32.31Mi ± 0%       ~ (p=1.000 n=6)
BenchSaveResultsUpdateChanged/N=1000-4       796.3Mi ± 1%   796.9Mi ± 1%       ~ (p=0.310 n=6)
geomean                                      322.9Mi        322.9Mi       +0.02%

                                         │ bench-base.txt │           bench-head.txt           │
                                         │   allocs/op    │  allocs/op    vs base              │
BenchSaveResultsSeed/N=1000-4                446.5k ±  0%   446.4k ±  0%       ~ (p=0.615 n=6)
BenchSaveResultsUpdateUnchanged/N=1000-4     404.7k ±  0%   404.7k ±  0%       ~ (p=0.699 n=6)
BenchSaveResultsUpdateChanged/N=1000-4       1.002M ± 13%   1.002M ± 13%       ~ (p=0.558 n=6)
geomean                                      565.7k         565.7k        +0.00%

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

Warning

Rate limit exceeded

@adityathebe has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 32 minutes and 23 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e360fdb0-0a7b-4522-af2a-bfcb4c076ad4

📥 Commits

Reviewing files that changed from the base of the PR and between 71d2456 and 3043d83.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • bench/config_items_save_results_bench_test.go
  • go.mod
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/config-properties-benchmark
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feat/config-properties-benchmark

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 6, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgolang/​github.com/​flanksource/​duty@​v1.0.1301 ⏵ v1.0.1303-0.20260506141750-2f51bc8b085175 +1100100100100

View full report

@adityathebe adityathebe force-pushed the feat/config-properties-benchmark branch from b76dac3 to 3043d83 Compare May 6, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant