Skip to content

fix: avoid setting User-Agent header in .NET Framework #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deleteLater merged 5 commits into from
Jun 4, 2025
Merged

fix: avoid setting User-Agent header in .NET Framework #25

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0a9e177
avoid setting User-Agent header in .NET Framework
deleteLater Jun 4, 2025
2879223
exclude net462 example project
deleteLater Jun 4, 2025
2328d53
revert wrong change
deleteLater Jun 4, 2025
4f736bd
remove NET462 Console App example
deleteLater Jun 4, 2025
00d84a1
add reference
deleteLater Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/FeatBit.ServerSdk/Transport/WebSocketTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,16 @@ public async Task StartAsync(
private static async Task<WebSocket> DefaultWebSocketFactory(Uri uri, CancellationToken cancellationToken)
{
var webSocket = new ClientWebSocket();

// reference: https://github.com/dotnet/aspnetcore/blob/main/src/SignalR/clients/csharp/Http.Connections.Client/src/Internal/WebSocketsTransport.cs#L98-L105
// Full Framework will throw when trying to set the User-Agent header
// So avoid setting it in netstandard2.0 and only set it in netstandard2.1 and higher
#if !NETSTANDARD2_0 && !NETFRAMEWORK
webSocket.Options.SetRequestHeader("User-Agent", HttpConstants.UserAgent);
#else
// Set an alternative user agent header on Full framework
webSocket.Options.SetRequestHeader("X-FeatBit-User-Agent", HttpConstants.UserAgent);
#endif

try
{
Expand Down