fix: avoid setting User-Agent header in .NET Framework#25
Merged
deleteLater merged 5 commits intomainfrom Jun 4, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where setting the "User-Agent" header on .NET Framework would throw an exception.
- Implements conditional compilation to set an alternative header ("X-FeatBit-User-Agent") on Full Framework
- Includes clear inline comments referencing the SignalR client implementation as context
Comments suppressed due to low confidence (1)
src/FeatBit.ServerSdk/Transport/WebSocketTransport.cs:102
- Ensure that the use of the alternative header 'X-FeatBit-User-Agent' is supported by the server and is documented so that maintainers understand why a non-standard header is used in Full Framework builds.
webSocket.Options.SetRequestHeader("X-FeatBit-User-Agent", HttpConstants.UserAgent);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #24
caused by 3dd26ec
reference:
https://github.com/dotnet/aspnetcore/blob/3aa03f47c740a867a99fb7240509f988246bc01c/src/SignalR/clients/csharp/Http.Connections.Client/src/Internal/WebSocketsTransport.cs#L98-L105