Skip to content

fix: avoid setting User-Agent header in .NET Framework#25

Merged
deleteLater merged 5 commits intomainfrom
fix/cannot-be-set-user-agent-header
Jun 4, 2025
Merged

fix: avoid setting User-Agent header in .NET Framework#25
deleteLater merged 5 commits intomainfrom
fix/cannot-be-set-user-agent-header

Conversation

@deleteLater
Copy link
Copy Markdown
Contributor

@deleteLater deleteLater commented Jun 4, 2025

@deleteLater deleteLater self-assigned this Jun 4, 2025
@deleteLater deleteLater added the bug Something isn't working label Jun 4, 2025
@deleteLater deleteLater moved this to In Progress in FeatBit Jun 4, 2025
@deleteLater deleteLater merged commit 0cfb263 into main Jun 4, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in FeatBit Jun 4, 2025
@deleteLater deleteLater deleted the fix/cannot-be-set-user-agent-header branch June 4, 2025 15:51
@deleteLater deleteLater requested a review from Copilot June 4, 2025 16:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where setting the "User-Agent" header on .NET Framework would throw an exception.

  • Implements conditional compilation to set an alternative header ("X-FeatBit-User-Agent") on Full Framework
  • Includes clear inline comments referencing the SignalR client implementation as context
Comments suppressed due to low confidence (1)

src/FeatBit.ServerSdk/Transport/WebSocketTransport.cs:102

  • Ensure that the use of the alternative header 'X-FeatBit-User-Agent' is supported by the server and is documented so that maintainers understand why a non-standard header is used in Full Framework builds.
webSocket.Options.SetRequestHeader("X-FeatBit-User-Agent", HttpConstants.UserAgent);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

The 'User-Agent' header must be modified using the appropriate property or method.

2 participants