Skip to content

Fix edge region identification by converting cell to matrix #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
askhamwhat merged 2 commits into from
Mar 16, 2026
Merged

Fix edge region identification by converting cell to matrix #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baf7cf4
Fix edge region identification by converting cell to matrix
tristangdwl Mar 15, 2026
8f4d068
update edge labeling test
tristangdwl Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chunkie/@chunkgraph/find_edge_regions.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
edge_regs = zeros(2,size(obj.edgesendverts,2));
nreg = length(obj.regions);
for i = 1:nreg
id_edge = obj.regions{i}{1};
id_edge = cell2mat(obj.regions{i});
edge_regs(1,id_edge(id_edge>0)) = i;
edge_regs(2,-id_edge(id_edge<0)) = i;
end
Expand Down
9 changes: 8 additions & 1 deletion devtools/test/chunkgrphregionTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,14 @@ function chunkgrphregionTest0()
end
end


edgereg = find_edge_regions(cgrph);
for i = 1:7
edges = cell2mat(rgntrue{i});
assert(all(edgereg(1,edges(edges>0)) == i))
assert(all(edgereg(2,abs(edges(edges<0))) == i))
end
assert(min(edgereg(:))==1)
assert(max(edgereg(:))==length(cgrph.regions))

end

Expand Down
Loading