Fix edge region identification by converting cell to matrix#163
Merged
askhamwhat merged 2 commits intomasterfrom Mar 16, 2026
Merged
Fix edge region identification by converting cell to matrix#163askhamwhat merged 2 commits intomasterfrom
askhamwhat merged 2 commits intomasterfrom
Conversation
Member
|
@tristangdwl nice find! could you add a few lines to devtools/test/chunkgraph_basicTest.m that would trigger the old bug? |
Collaborator
Author
|
@askhamwhat good point! I have added that test. |
askhamwhat
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function that returns the region on each side of a chunkgraph edge broke when there were multiple disjoint obstacles, e.g. if we computed the scattering from several squares.