Fix malformed private field in package.json files#35802
Fix malformed private field in package.json files#35802Pantkartik wants to merge 1 commit intofacebook:mainfrom
Conversation
This commit corrects the type of the 'private' field in several package.json files from string to boolean, ensuring compliance with the npm specification.
|
Hi @Pantkartik! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Since PR #35802 has been updated to cover all the malformed fields I identified during my audit, I am closing this PR to avoid duplication. Glad to see the entire monorepo is getting fixed! |
Summary
This PR fixes a compliance issue with the npm package.json specification where the
privatefield was incorrectly typed as a string ("true") instead of a boolean (true).While some tools may handle this leniently, strict package scanners and validation pipelines (such as ScanCode.io) fail when encountering this malformed metadata. According to the npm documentation, the
privatefield must be a boolean.Approach & Changes
I conducted a codebase-wide audit to identify all instances of this pattern, rather than fixing only the reported file.
I updated the
privatefield from"true"totruein the following files:privatefield in react-devtools-fusebox package.json #35793)Test Plan
grep -r "\"private\": \"true\"" .) to confirm no other occurrences remain in the repository.Related Issues
Fixes #35793