fix: correct malformed private field type in multiple package.json files#35806
Closed
dill-lk wants to merge 1 commit intofacebook:mainfrom
Closed
fix: correct malformed private field type in multiple package.json files#35806dill-lk wants to merge 1 commit intofacebook:mainfrom
dill-lk wants to merge 1 commit intofacebook:mainfrom
Conversation
Author
|
Since PR #35802 has been updated to cover all the malformed fields I identified during my audit, I am closing this PR to avoid duplication. Glad to see the entire monorepo is getting fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
While auditing the React monorepo for metadata compliance, I discovered that multiple
package.jsonfiles were using a string"true"for theprivatefield instead of the booleantruerequired by the npm specification.Changes
This PR corrects the
privatefield type fromstringtobooleanin the following locations to ensure consistency and prevent failures in automated package metadata scanning tools:packages/react-devtools-fusebox/package.jsoncompiler/packages/react-forgive/client/package.jsoncompiler/packages/react-forgive/server/package.jsonImpact
Malformed metadata often causes failures in security, license, and compliance scanning tools (such as ScanCode.io) that strictly validate package metadata types. This fix ensures the repository remains compliant with industry-standard package specifications.
Verification
package.jsonfiles in the monorepo usinggrep.privatefield is now correctly recognized as a boolean.