Migrate folly generate_cmake.py to shared library + add select() support#2595
Closed
afrind wants to merge 1 commit intofacebook:mainfrom
Closed
Migrate folly generate_cmake.py to shared library + add select() support#2595afrind wants to merge 1 commit intofacebook:mainfrom
afrind wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: - Import shared parsing functions from opensource.buck_to_cmake.buck_parser instead of reimplementing extract_list, extract_external_deps, etc. - Add select() support for deps/exported_deps: non-DEFAULT branches are now emitted as conditional CMake variables (if/endif blocks) - Remove EXTRA_TARGET_DEPS for folly/result/epitaph since the dep is now correctly picked up from the select() DEFAULT branch - Regenerate folly/detail/CMakeLists.txt and folly/portability/provide/CMakeLists.txt with newly discovered conditional deps Differential Revision: D95579501
|
This pull request has been merged in da3cbd9. |
meta-codesync Bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Mar 8, 2026
Summary: X-link: facebook/folly#2595 - Import shared parsing functions from opensource.buck_to_cmake.buck_parser instead of reimplementing extract_list, extract_external_deps, etc. - Add select() support for deps/exported_deps: non-DEFAULT branches are now emitted as conditional CMake variables (if/endif blocks) - Remove EXTRA_TARGET_DEPS for folly/result/epitaph since the dep is now correctly picked up from the select() DEFAULT branch - Regenerate folly/detail/CMakeLists.txt and folly/portability/provide/CMakeLists.txt with newly discovered conditional deps Reviewed By: yfeldblum Differential Revision: D95579501 fbshipit-source-id: f14ba05082623774a7f4191454f8e1362a26b961
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
instead of reimplementing extract_list, extract_external_deps, etc.
now emitted as conditional CMake variables (if/endif blocks)
correctly picked up from the select() DEFAULT branch
with newly discovered conditional deps
Differential Revision: D95579501