Make folly_detail_perf_scoped depend on folly_subprocess#2590
Closed
mszabo-wikia wants to merge 1 commit intofacebook:mainfrom
Closed
Make folly_detail_perf_scoped depend on folly_subprocess#2590mszabo-wikia wants to merge 1 commit intofacebook:mainfrom
mszabo-wikia wants to merge 1 commit intofacebook:mainfrom
Conversation
On Linux platforms PerfScoped.cpp pulls in Subprocess.h, so linking in folly_detail_perf_scoped either on its own or via the catch-all target fails unless folly_subprocess is explicitly passed in as well. Make the dependency explicit instead.
Contributor
|
This file is now generated based on our BUCK file. Let me take a look |
Contributor
|
I see what's wrong with our generator and will try to update it soon. |
Contributor
|
See #2595 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux platforms PerfScoped.cpp pulls in Subprocess.h, so linking in folly_detail_perf_scoped either on its own or via the catch-all target fails unless folly_subprocess is explicitly passed in as well. Make the dependency explicit instead.