Conversation
Coordinator: SyncAck must not inflate steps_since_avg, must satisfy nccl_ack. Worker: scheduler output reaches optimizer, lr_scale multiplies it, scheduler step argument advances per batch. Graph: set_scheduler drives optimizer LR through step(), lr_scale multiplies, no scheduler leaves LR untouched. Adds GpuWorker::current_lr() accessor for test introspection.
Asserts that the same MultiStepLR produces identical optimizer LR trajectories across all three training paths: manual (reference), GpuWorker (builder), and Graph::step() (sync). Covers both unscaled and lr_scale != 1.0.
Replace symmetric 25%/75% drift check with one-sided before/after pattern, matching test_backward_frees_grad_fn_chain. live_tensor_count is a global atomic shared with concurrent tests; symmetric thresholds flake when other tests' tensors are created or freed during the measurement window. A real leak only manifests as monotonic growth, so tolerate shrinkage and assert only on growth (< 200, scaled from the 100 used in the simpler test). RSS threshold loosened from 30MB to 100MB: glibc allocator behavior under CI memory pressure can hold pages well past last use.
- api_ref.rs: backtick-escape <tag> and <repo-name> placeholders that rustdoc was parsing as unclosed HTML tags - coordinator.rs: qualify ConvergenceGuard link as super::ConvergenceGuard - datasets/mod.rs: qualify BatchDataSet/DataLoader links as super::* - pooling.rs: drop redundant explicit link target on adaptive_avg_pool2d
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.