[luv-325] fix: stop translate-docs workflow from dropping translations when an auto-PR is open#325
Merged
NiveditJain merged 1 commit intomainfrom May 9, 2026
Merged
[luv-325] fix: stop translate-docs workflow from dropping translations when an auto-PR is open#325NiveditJain merged 1 commit intomainfrom
NiveditJain merged 1 commit intomainfrom
Conversation
…s when an auto-PR is open Previously the consolidate step exited early if any "[auto] update translations" PR was open and the cache-save step ran first, so translations queued during a busy push window were marked done in cache but never landed in any branch. Empirically verified against the README rewrite in #321: the per-language `Translate` jobs successfully translated all 14 i18n READMEs (visible in run 25588145237 logs as `translated (3258+3048 tokens)` lines), but the consolidate job logged `Translation PR already open. Skipping.` and PR #324 only contained 14 dashboard.mdx files — the 14 README translations were stuck on the pre-redesign 358-line layout while the English README dropped to 171 lines. Fix: when an auto-PR is open, snapshot the freshly-generated docs/ tree + merged cache via tar before any branch ops, fetch and force-checkout the existing PR's branch, then untar on top so the newest English source always wins. PR creation only fires when no existing PR matched. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 14 i18n READMEs are stuck on the pre-redesign 358-line layout while the English README is now 171 lines. Root cause is a
translate-docs.ymlconsolidate-step bug that drops translations when an auto-PR is mid-flight.The per-language
Translatejobs in run 25588145237 (triggered by the README rewrite in #321) successfully re-translated all 14 i18n READMEs — visible in logs astranslated (3258+3048 tokens)lines. The consolidate job then loggedTranslation PR already open. Skipping.because an unrelated auto-PR was mid-flight, and exited 0. But the cache-save step had already run before that check, so the cache advanced to mark the lost translations as done. The next two runs (#322, #323) saw the README as cached and PR #324 only contained 14 dashboard.mdx files.Fix
When an
[auto] update translationsPR is already open:docs/tree + merged cache via tar (before any branch ops)PR creation only fires when no existing PR matched.
Test plan
mainafter merge withforce=trueand confirm a new auto-PR contains all 14 README translations matching the current 171-line English layout🤖 Generated with Claude Code
Summary by CodeRabbit