Skip to content

fail proxy loudly #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xzrderek merged 9 commits into from
Oct 28, 2025
Merged

fail proxy loudly #293

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dc2a6f5
fail proxy loudly
xzrderek Oct 26, 2025
ea38ccd
lock
xzrderek Oct 26, 2025
015e856
fix
xzrderek Oct 27, 2025
8ec64ce
fix test
xzrderek Oct 27, 2025
5a85830
one fix at a time
xzrderek Oct 27, 2025
ae6d2cd
test
xzrderek Oct 27, 2025
2827c52
revert
xzrderek Oct 27, 2025
fb1b9a2
test
xzrderek Oct 27, 2025
d42e464
remove
xzrderek Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions eval_protocol/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,16 @@
try:
from .proxy import create_app, AuthProvider, AccountInfo
except ImportError:
create_app = None
AuthProvider = None
AccountInfo = None

def _proxy_import_error(*args, **kwargs):
raise ImportError(
"Proxy functionality requires additional dependencies. "
"Please install with: pip install eval-protocol[proxy]"
)

create_app = _proxy_import_error
AuthProvider = _proxy_import_error
AccountInfo = _proxy_import_error
Copy link
Copy Markdown

@cursor cursor Bot Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Delayed ImportError in Proxy Assignment

Assigning the _proxy_import_error function to AuthProvider and AccountInfo (intended as classes) means type annotations and isinstance checks won't immediately raise an ImportError. The error only appears when the function is called, which delays feedback compared to the previous None assignment.

Fix in Cursor Fix in Web

Copy link
Copy Markdown
Collaborator

@dphuang2 dphuang2 Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xzrderek this is how it is recommended to solve this:

try:
    from real_module import AuthProvider
except ImportError:
    class AuthProvider:
        def __init__(self, *args, **kwargs):
            raise ImportError(
                "Proxy functionality requires additional dependencies. "
                "Please install with: pip install eval-protocol[proxy]"
            )

Code that expects a class, uses type hints or isinstance detection, or needs to inspect Class attributes will work as normal, right up until someone tries to “use” the missing feature. That’s when it fails loudly and clearly.

Comment thread
xzrderek marked this conversation as resolved.
Outdated


warnings.filterwarnings("default", category=DeprecationWarning, module="eval_protocol")
Expand Down
6 changes: 6 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,12 @@ langgraph_tools = [
"langchain-fireworks>=0.3.0",
]

proxy = [
"redis>=5.0.0",
"langfuse>=2.0.0",
"uuid6>=2025.0.0",
]

[project.scripts]
fireworks-reward = "eval_protocol.cli:main"
eval-protocol = "eval_protocol.cli:main"
Expand Down
31 changes: 30 additions & 1 deletion uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading