Skip to content

fail proxy loudly#293

Merged
xzrderek merged 9 commits intomainfrom
derekx/fail-proxy-loudly
Oct 28, 2025
Merged

fail proxy loudly#293
xzrderek merged 9 commits intomainfrom
derekx/fail-proxy-loudly

Conversation

@xzrderek
Copy link
Copy Markdown
Contributor

@xzrderek xzrderek commented Oct 26, 2025

Note

Introduce proxy optional extra with required deps and explicit ImportError fallbacks; update remote Fireworks tests to fetch traces via adapter and adjust CI to ignore them.

  • Proxy/runtime behavior:
    • Add explicit fallbacks in eval_protocol/__init__.py for create_app, AuthProvider, and AccountInfo that raise ImportError with install hint when proxy deps are missing (with pyright ignore for type).
  • Optional dependencies:
    • Introduce proxy extra in pyproject.toml with redis, langfuse, and uuid6.
  • Remote Fireworks tests:
    • tests/remote_server/test_remote_fireworks.py: add Fireworks tracing output data loader (fireworks_output_data_loader) to fetch traces via FireworksTracingAdapter; track and assert multiple rollout_ids; increase timeout.
    • tests/remote_server/test_remote_fireworks_propagate_status.py: add Fireworks tracing output data loader and use it in RemoteRolloutProcessor while asserting propagated error status.
  • CI:
    • Update .github/workflows/ci.yml to ignore tests/remote_server/test_remote_fireworks.py (and keep ignoring the propagate-status test) in parallel test run.
  • Lockfile:
    • Update uv.lock to include proxy extras and packages (redis, langfuse, uuid6).

Written by Cursor Bugbot for commit d42e464. This will update automatically on new commits. Configure here.

cursor[bot]

This comment was marked as outdated.

@xzrderek xzrderek requested a review from dphuang2 October 26, 2025 10:53
Copy link
Copy Markdown
Collaborator

@dphuang2 dphuang2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, should be easy to fix

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@xzrderek xzrderek merged commit a0b02aa into main Oct 28, 2025
9 of 13 checks passed
@xzrderek xzrderek deleted the derekx/fail-proxy-loudly branch October 28, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants