Skip to content

Fix github actions test failure #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xzrderek merged 2 commits into from
Sep 20, 2025
Merged

Fix github actions test failure #198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fde105b
Fix: Ensure sqlite logger is enabled in CI tests
cursoragent Sep 20, 2025
826a5fa
formatting
xzrderek Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tests/pytest/test_pytest_ensure_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,15 @@ async def test_ensure_logging(monkeypatch):
"""
Ensure that default SQLITE logger gets called by mocking the storage and checking that the storage is called.
"""
# Ensure default sqlite logger is enabled in CI environments and reset lazy cache
monkeypatch.setenv("DISABLE_EP_SQLITE_LOG", "0")
from eval_protocol.dataset_logger import default_logger as _dl

# Reset the cached underlying logger so it re-initializes with the current env
try:
monkeypatch.setattr(_dl, "_logger", None, raising=False)
except Exception:
pass
# Mock the SqliteEvaluationRowStore to track calls
mock_store = Mock()
mock_store.upsert_row = Mock()
Expand Down
Loading