Fix github actions test failure

[xzrderek]

---

name: Pull Request
about: Propose changes to the codebase
title: "Fix: test_ensure_logging failure in CI due to disabled SQLite logger"
labels: ''
assignees: ''

---

Description

This PR fixes a flaky CI test, tests/pytest/test_pytest_ensure_logging.py::test_ensure_logging, which was failing because the SQLite logger was inadvertently disabled by the DISABLE_EP_SQLITE_LOG environment variable in the CI environment.

The test mocks SqliteEvaluationRowStore and asserts that its upsert_row method is called. However, when DISABLE_EP_SQLITE_LOG was set to "1" (as it was in CI), the NoOp logger was initialized instead of SqliteDatasetLoggerAdapter, preventing upsert_row from ever being called on the mock.

The fix involves explicitly setting DISABLE_EP_SQLITE_LOG="0" within the test using monkeypatch.setenv and resetting the lazy logger cache (default_logger._logger = None). This ensures the SqliteDatasetLoggerAdapter is correctly initialized and used during the test, allowing upsert_row to be called as expected. This change only affects the test environment and does not alter any production logic.

Fixes # (issue)
Implements # (issue)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Refactoring/Code cleanup
• Build/CI/CD related changes
• Other (please describe):

How Has This Been Tested?

The fix was verified by running the specific failing test locally after applying the changes.

• pytest -q tests/pytest/test_pytest_ensure_logging.py::test_ensure_logging

Test Configuration:

• Firmware version: N/A
• Hardware: N/A
• Toolchain: N/A
• SDK: N/A

Checklist:

• My code follows the style guidelines of this project (ran black ., isort ., flake8 .)
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings

Screenshots (if applicable)

N/A

Additional context

This change is purely for test robustness in CI and does not impact the application's runtime behavior or logging configuration outside of this specific test.

---

 

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}