Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/tesla/adapter/mint.ex
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,9 @@ if Code.ensure_loaded?(Mint.HTTP) do

{:done, ^ref}, acc ->
Map.put(acc, :done, true)

{:push_promise, ^ref, _promised_ref, _headers}, acc ->
acc
Comment thread
yordis marked this conversation as resolved.
end)
end
end
Expand Down
14 changes: 14 additions & 0 deletions test/support/mint_push_promise_handlers.ex
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
defmodule Tesla.TestSupport.MintPushPromiseIndexHandler do
def init(req, state) do
:ok = :cowboy_req.push("/style.css", %{}, req)
req = :cowboy_req.reply(200, %{"content-type" => "text/plain"}, "original response", req)
{:ok, req, state}
end
end

defmodule Tesla.TestSupport.MintPushPromiseStyleHandler do
def init(req, state) do
req = :cowboy_req.reply(200, %{"content-type" => "text/css"}, "body { color: red; }", req)
{:ok, req, state}
end
end
99 changes: 99 additions & 0 deletions test/tesla/adapter/mint_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -370,4 +370,103 @@ defmodule Tesla.Adapter.MintTest do
defp reused_conn_opts(conn, original, opts) do
Keyword.merge([conn: conn, original: original, close_conn: false], opts)
end

describe "issue #450 - handle missing Mint response types" do
setup do
listener_ref = :"mint-push-promise-#{System.unique_integer([:positive])}"
dispatch = push_promise_dispatch()
priv_dir = :code.priv_dir(:httparrot)

{:ok, _pid} =
:cowboy.start_tls(
listener_ref,
[
port: 0,
certfile: priv_dir ++ ~c"/ssl/server.crt",
keyfile: priv_dir ++ ~c"/ssl/server.key"
],
%{env: %{dispatch: dispatch}}
)

on_exit(fn -> :cowboy.stop_listener(listener_ref) end)

{_, port} = :ranch.get_addr(listener_ref)

{:ok,
push_url: "https://localhost:#{port}",
push_cacertfile: Path.join([to_string(priv_dir), "ssl/server-ca.crt"])}
end

test "handles connection errors gracefully" do
uri = URI.parse(@http)

request = %Env{
method: :get,
url: "http://#{uri.host}:1234"
}

assert {:error, _reason} = call(request)
end

test "handles malformed requests without crashes" do
request = %Env{
method: :get,
url: "#{@http}/status/500"
}

assert {:ok, %Env{} = response} = call(request)
assert response.status == 500
end

test "handles timeout scenarios without crashes" do
request = %Env{
method: :get,
url: "#{@http}/delay/2"
}

assert {:error, :timeout} = call(request, timeout: 100)
end

test "handles connection drops during streaming" do
request = %Env{
method: :get,
url: "#{@http}/stream-bytes/1000"
}

assert {:ok, %Env{} = response} = call(request, body_as: :stream)
assert response.status == 200

data = Enum.join(response.body)
assert byte_size(data) > 0
end

test "handles push_promise responses from a real HTTP/2 server", %{
push_url: push_url,
push_cacertfile: push_cacertfile
} do
request = %Env{
method: :get,
url: "#{push_url}/index.html"
}

assert {:ok, %Env{} = response} =
call(request,
protocols: [:http2],
transport_opts: [cacertfile: push_cacertfile]
)

assert response.status == 200
assert response.body == "original response"
end
end

defp push_promise_dispatch do
:cowboy_router.compile([
{:_,
[
{"/index.html", Tesla.TestSupport.MintPushPromiseIndexHandler, []},
{"/style.css", Tesla.TestSupport.MintPushPromiseStyleHandler, []}
]}
])
end
end
Loading