Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances response handling in the Tesla Mint adapter to fix issue #450 by improving the message pattern matching robustness and adding comprehensive test coverage.
- Added error handling patterns for HTTP/2 features and unknown response types
- Extended test coverage for various response scenarios including timeouts, streaming, and error conditions
- Improved forward compatibility by gracefully handling unsupported message types
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/tesla/adapter/mint.ex | Added pattern matching for error, pong, push_promise, and unknown message types |
| test/tesla/adapter/mint_test.exs | Added comprehensive test suite covering normal requests, errors, timeouts, streaming, and large responses |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
|
@teamon could you give me a hand reviewing this one? |
yordis
force-pushed
the
yordis/fixes-450
branch
3 times, most recently
from
40d9899 to
4cc6119
Compare
fixes #450 Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/fixes-450
branch
from
4cc6119 to
398a359
Compare
Member
Author
|
I am giving up how to properly test this, @teamon any clue 😭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #450
Signed-off-by: Yordis Prieto yordis.prieto@gmail.com