Skip to content

Replace usage of unshift with concat #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
calumptrck wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace usage of unshift with concat #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,11 @@ module.exports = function flatten (array) {
// only process `value` if it has some elements.
if (value.length > 0) {

// to provide the `value` array to splice() we need to add the
// splice() args to its front.
// these args tell it to splice at `i` and delete what's at `i`.
value.unshift(i, 1)

// NOTE:
// This is an in-place change; it mutates `array`.
// prepend our value with [i,1] to tell splice to
// start splicing at `i` and delete the element at `i`.
// NOTE: This is an in-place change; it mutates `array`.
// To avoid this, wrap your array like: flatten([myarray])
array.splice.apply(array, value)

// take (i, 1) back off the `value` front
// so it remains "unchanged".
value.splice(0, 2)
array.splice.apply(array, [i,1].concat(value))
} else {
// remove an empty array from `array`
array.splice(i, 1)
Expand Down